Skip to content

Add short expectation-setter about show if fields - #1146

Merged
BryceStevenWilley merged 2 commits into
mainfrom
expectation_showif
Nov 20, 2026
Merged

BryceStevenWilley merged 2 commits into
mainfrom
expectation_showif

Conversation

@BryceStevenWilley

Copy link
Copy Markdown
Contributor

Note to users that more fields might appear depending on their answers. This was a direct recommendation from a user in MLH's accessibility testing.

Stuck with the suggested language, for fear of trying to over explain things.

Fix #1145

Note to users that more fields might appear depending on their answers. This
was a direct recommendation from a user in MLH's accessibility testing.

Fix #1145
@BryceStevenWilley BryceStevenWilley self-assigned this Nov 18, 2026

@nonprofittechy nonprofittechy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine; willing to trust the experts here. This is a small enough addition (and a complete sentence) that to me I think we can add machine translated version of this phrase to existing translations so we don't break existing interviews translated first pages, but that can be a follow-up PR.

@BryceStevenWilley

Copy link
Copy Markdown
Contributor Author

Thanks for the reminder, I need to get better at remembering translations when doing copyedit updates. I'll can machine translate those bits now in this PR in a separate commit.

For existing xlsx translations of Spanish, Hatian Creole, and Portuguese (Brazillian),
all from Google Translate. The Creole and Portuguese entries also needed to change
other parts of the screen ("Court Forms Online Project" -> "${ AL_ORGANIZATION_TITLE }" )
to work.

Tested by adding `al_interview_languages` to `al_question_test`. Needed to also update
the `orig_text` in the Portugueses and Creole spreadsheets to be exactly what was in
the question (including a trailing newline).
@BryceStevenWilley

Copy link
Copy Markdown
Contributor Author

Got the translations in a separate commit, but the Portuguese and Creole translation sheets were fairly out of date; just tried to fix the one screen that was changed and eventually got it, but it's fairly annoying (was missing a trailing newline, which I couldn't easily see in the excel and I didn't think made a difference? idk).

Mostly a note for later to redo the translation spreadsheets for the existing languages, even if we don't do the translations fully right now, I think they might be missing a bit of text.

Screenshot 2026-11-19 at 5 20 57 PM

@BryceStevenWilley
BryceStevenWilley merged commit 14e9446 into main Nov 20, 2026
8 checks passed
@BryceStevenWilley
BryceStevenWilley deleted the expectation_showif branch November 20, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New fields / notes with show js should be announced to screen readers

2 participants